bluca

bluca commented on issue pkgconf/pkgconf#36

define-prefix: skip one level if it ends up in /lib

Thanks, moving discussion over to the freedesktop PR.

3 months ago

bluca commented on issue pkgconf/pkgconf#36

define-prefix: skip one level if it ends up in /lib

Thanks for having a look. Is there a link to the CI results?

3 months ago

bluca commented on issue pkgconf/pkgconf#36

define-prefix: skip one level if it ends up in /lib

Is there a CI system? running the command used in the test manually works, but I don't have kyua available

3 months ago

bluca commented on issue pkgconf/pkgconf#36

define-prefix: skip one level if it ends up in /lib

Same change proposed to pkg-config: https://gitlab.freedesktop.org/pkg-config/pkg-config/merge_requests/4

3 months ago

bluca created pull request pkgconf/pkgconf#36

define-prefix: skip one level if it ends up in /lib

3 months ago

bluca pushed to define_prefix_multiarch at bluca/pkgconf

  • 9309614b22 define-prefix: skip one level if it ends up in /lib In Debian and Ubuntu the multiarch filesystem layout looks as follows: /usr/lib/x86_64-linux-gnu/pkgconfig/ /usr/lib/i386-linux-gnu/pkgconfig/ Which means when --define-prefix skips to the grand-parent directory of pkgconfig, it ends up in /usr/lib rather than /usr as it's supposed to. This causes for example the include path to be printed as: /usr/lib/include which is wrong and breaks applications. Check if the new directory is 'lib' and if it is go one step above. A new series of unit tests is added with this layout.
  • 4ce0a023c4 define-prefix: skip one level if it ends up in /lib In Debian and Ubuntu the multiarch filesystem layout looks as follows: /usr/lib/x86_64-linux-gnu/pkgconfig/ /usr/lib/i386-linux-gnu/pkgconfig/ Which means when --define-prefix skips to the grand-parent directory of pkgconfig, it ends up in /usr/lib rather than /usr as it's supposed to. This causes for example the include path to be printed as: /usr/lib/include which is wrong and breaks applications. Check if the new directory is 'lib' and if it is go one step above. A new series of unit tests is added with this layout.
  • Compare 2 commits »

3 months ago

bluca pushed to define_prefix_multiarch at bluca/pkgconf

3 months ago

bluca pushed to define_prefix_multiarch at bluca/pkgconf

  • 083c83135c test
  • 4ce0a023c4 define-prefix: skip one level if it ends up in /lib In Debian and Ubuntu the multiarch filesystem layout looks as follows: /usr/lib/x86_64-linux-gnu/pkgconfig/ /usr/lib/i386-linux-gnu/pkgconfig/ Which means when --define-prefix skips to the grand-parent directory of pkgconfig, it ends up in /usr/lib rather than /usr as it's supposed to. This causes for example the include path to be printed as: /usr/lib/include which is wrong and breaks applications. Check if the new directory is 'lib' and if it is go one step above. A new series of unit tests is added with this layout.

3 months ago

bluca created repository bluca/pkgconf

3 months ago